linux-kernel - Re: [PATCH v3 2/4] iio: accel: adxl345: Use I2C regmap instead of direct I2C access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vca29-H050MgCvdo986+QA5odJmAF3_AwQURMYZOb=wUA@mail.gmail.com>
Date:   Thu, 23 Feb 2017 18:27:52 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Eva Rachel Retuya <eraretuya@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Michael Hennerich <michael.hennerich@...log.com>,
        daniel.baluta@...il.com, amsfield22@...il.com,
        Florian Vaussard <florian.vaussard@...g-vd.ch>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 2/4] iio: accel: adxl345: Use I2C regmap instead of
 direct I2C access

On Wed, Feb 22, 2017 at 12:22 PM, Eva Rachel Retuya <eraretuya@...il.com> wrote:
> Convert the driver to use regmap instead of I2C-specific functions.
> Also, introduce the header file "adxl345.h" and export the probe and
> remove functions. This is done in preparation for splitting this driver
> into core and I2C-specific code as well as introduction of SPI driver.
>
> Signed-off-by: Eva Rachel Retuya <eraretuya@...il.com>

Is it possible to use device just after this very patch?
For me it seems there is bisectability issue.

> -static const struct i2c_device_id adxl345_i2c_id[] = {
> -       { "adxl345", 0 },
> -       { }
> -};
> -
> -MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id);
> -
> -static struct i2c_driver adxl345_driver = {
> -       .driver = {
> -               .name   = "adxl345",
> -       },
> -       .probe          = adxl345_probe,
> -       .remove         = adxl345_remove,
> -       .id_table       = adxl345_i2c_id,
> -};
> -
> -module_i2c_driver(adxl345_driver);
> +EXPORT_SYMBOL_GPL(adxl345_common_remove);

-- 
With Best Regards,
Andy Shevchenko