linux-kernel - Re: [PATCH v3 3/4] iio: accel: adxl345: Split driver into core and I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcWethtVW4Q6Q7Y+E9b6s32mf9YFT8wecXV7dDUS3asLQ@mail.gmail.com>
Date:   Thu, 23 Feb 2017 18:36:42 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Eva Rachel Retuya <eraretuya@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, linux-iio@...r.kernel.org,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Michael Hennerich <michael.hennerich@...log.com>,
        Daniel Baluta <daniel.baluta@...il.com>,
        Alison Schofield <amsfield22@...il.com>,
        Florian Vaussard <florian.vaussard@...g-vd.ch>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>
Subject: Re: [PATCH v3 3/4] iio: accel: adxl345: Split driver into core and I2C

On Wed, Feb 22, 2017 at 12:23 PM, Eva Rachel Retuya <eraretuya@...il.com> wrote:
> Move I2C-specific code into its own file and rely on regmap to access
> registers. The core code provides access to x, y, z and scale readings.

Like Lars already pointed to possibility of use of this in ACPI based
platforms, I would add a reference to
commit 01427fe7c4b9 ("Input: adxl34x - make it enumerable in ACPI environment").

Please fix your patches accordingly.


> +static const struct i2c_device_id adxl345_i2c_id[] = {
> +       { "adxl345", 0 },
> +       { }
> +};
> +
> +MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id);
> +
> +#ifdef CONFIG_OF
> +static const struct of_device_id adxl345_of_match[] = {
> +       { .compatible = "adi,adxl345" },
> +       { },
> +};
> +
> +MODULE_DEVICE_TABLE(of, adxl345_of_match);
> +#endif
> +
> +static struct i2c_driver adxl345_i2c_driver = {
> +       .driver = {
> +               .name   = "adxl345_i2c",
> +               .of_match_table = of_match_ptr(adxl345_of_match),
> +       },
> +       .probe          = adxl345_i2c_probe,
> +       .remove         = adxl345_i2c_remove,
> +       .id_table       = adxl345_i2c_id,
> +};
> +
> +module_i2c_driver(adxl345_i2c_driver);
> +
> +MODULE_AUTHOR("Eva Rachel Retuya <eraretuya@...il.com>");
> +MODULE_DESCRIPTION("ADXL345 3-Axis Digital Accelerometer I2C driver");
> +MODULE_LICENSE("GPL v2");


-- 
With Best Regards,
Andy Shevchenko