linux-kernel - Re: LED devices & poll() for brightness attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170223210321.GB19376@amd>
Date:   Thu, 23 Feb 2017 22:03:21 +0100
From:   Pavel Machek <pavel@....cz>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     Richard Purdie <rpurdie@...ys.net>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        Darren Hart <dvhart@...radead.org>,
        platform-driver-x86@...r.kernel.org
Subject: Re: LED devices & poll() for brightness attribute

Hi!

> > > > 2) there may be more then one
> > > 
> > > Yes and script can be adjusted to use specific one (config option
> > > for script).
> > 
> > No, you should autoconfigure it,
> 
> Why? Because you prefer autoconfiguration and all other people must use 
> it only? Does not seems a good argument.
> 
> For machine which does not change, static policy file is enough too. And 
> for this simple case it will work correctly.
> 
> Why everybody must be forced to use some autoconfiguration and does not 
> allow user to use his own manual configuration?

Why everybody must be forced to poll() on brightness file?

> > actually. See N900, there are 6 leds controlling one backlight.
> 
> I'm not saying that one script must be universal for everything. My 
> script is enough for machine with single keyboard led. And for other 
> people who have only one backlight keyboard it will work fine too.

> For other cases something other could be written...

For other cases, you need to communicate with the desktop.

> > And I don't want led/brightness file to be used for interprocess
> > communication.
> 
> You are not forced to use something. I'm proposing extending current ABI 
> which can be used for processes who want those notification.

Your proposal does not help you with your problem, unless you get
desktop people to poll() on the brightness files, and do something
inteligent with the results.

Hmm. And doing something inteligent will be quite hard given that we
have 6 of those files on N900.

So, if you seriously want to do this, can you

1) write specification explaining how desktops should poll() the
brightness files

2) get someone to volunteer to implement that specification for at
least GNOME and KDE?

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)