lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20170224195731.GB4480@mwanda> Date: Fri, 24 Feb 2017 22:57:31 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Stefan Wahren <stefan.wahren@...e.com> Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>, mchehab@...nel.org, gregkh@...uxfoundation.org, f.fainelli@...il.com, rjui@...adcom.com, sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com, swarren@...dotorg.org, lee@...nel.org, eric@...olt.net, arnd@...db.de, devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org Subject: Re: [PATCH] staging: bcm2835: Fix a memory leak in error handling path On Fri, Feb 24, 2017 at 01:37:30PM +0100, Stefan Wahren wrote: > Hi Christophe, > > Am 19.02.2017 um 11:34 schrieb Christophe JAILLET: > >If 'kzalloc()' fails, we should release resources allocated so far, just as > >done in all other cases in this function. > > > >Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr> > >--- > >Not sure that the error handling path is correct. > >Is 'gdev[0]' freed? Should it be? > Yes, but I already sent a patch to fix this and your leak as well and Greg merged it. > sorry, didn't checked your patch yet. It takes like 30 seconds to review this patch. Do you use mutt? I have a macro that applies patches and loads vim at the right line. regards, dan carpenter
Powered by blists - more mailing lists