linux-kernel - Re: [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory' message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef03f4f4-ad76-8441-87b1-fe637f53977e@sakamocchi.jp>
Date:   Sun, 26 Feb 2017 17:04:16 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Mihai-Valentin DUMITRU <mihai.dumitru2201@...il.com>,
        perex@...ex.cz, tiwai@...e.com, heiko@...ech.de
Cc:     alsa-devel@...a-project.org, lgirdwood@...il.com,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        broonie@...nel.org,
        Mihai-Valentin DUMITRU <mihai.dumitru2201@...d.acs.upb.ro>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ASoC: rockchip: i2s: Remove unnecessary 'out of memory'
 message

On Feb 25 2017 19:18, Mihai-Valentin DUMITRU wrote:
> This was reported by checkpatch.pl
>
> Signed-off-by: Mihai-Valentin DUMITRU <mihai.dumitru2201@...il.com>
> ---
>  sound/soc/rockchip/rockchip_i2s.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
> index 974915cb4c4f..d02a1045fc0b 100644
> --- a/sound/soc/rockchip/rockchip_i2s.c
> +++ b/sound/soc/rockchip/rockchip_i2s.c
> @@ -551,10 +551,8 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
>  	int val;
>
>  	i2s = devm_kzalloc(&pdev->dev, sizeof(*i2s), GFP_KERNEL);
> -	if (!i2s) {
> -		dev_err(&pdev->dev, "Can't allocate rk_i2s_dev\n");
> +	if (!i2s)

The line for dev_warn() should be kept.

>  		return -ENOMEM;
> -	}
>
>  	i2s->dev = &pdev->dev;


Regards

Takashi Sakamoto