lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 26 Feb 2017 17:03:22 +0900
From:   Takashi Sakamoto <o-takashi@...amocchi.jp>
To:     Mihai Burduselu <michelcatalin@...il.com>, tiwai@...e.com,
        perex@...ex.cz
Cc:     Jose.Abreu@...opsys.com, alsa-devel@...a-project.org,
        lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        broonie@...nel.org, s.nawrocki@...sung.com,
        colin.king@...onical.com
Subject: Re: [PATCH] ASoC: dwc: remove 'out of memory' message

Hi,

On Feb 25 2017 20:03, Mihai Burduselu wrote:
> Reported by checkpatch.pl
> Signed-off-by: Mihai Burduselu <michelcatalin@...il.com>
> ---
>  sound/soc/dwc/designware_i2s.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> index 9c46e4112026..6479768cc6a1 100644
> --- a/sound/soc/dwc/designware_i2s.c
> +++ b/sound/soc/dwc/designware_i2s.c
> @@ -611,10 +611,8 @@ static int dw_i2s_probe(struct platform_device *pdev)
>  	const char *clk_id;
>
>  	dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL);
> -	if (!dev) {
> -		dev_warn(&pdev->dev, "kzalloc fail\n");
> +	if (!dev)

The line for 'dev_warn()' should be kept.

>  		return -ENOMEM;
> -	}
>
>  	dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL);
>  	if (!dw_i2s_dai)


Regards

Takashi Sakamoto

Powered by blists - more mailing lists