lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 26 Feb 2017 02:32:19 +0100 From: Andreas Färber <afaerber@...e.de> To: Jiancheng Xue <xuejiancheng@...ilicon.com> Cc: robh+dt@...nel.org, catalin.marinas@....com, will.deacon@....com, arnd@...db.de, xuwei5@...ilicon.com, devicetree@...r.kernel.org, mark.gregotski@...aro.org, linux-kernel@...r.kernel.org, yanhaifeng@...ilicon.com, peter.griffin@...aro.org, elder@...aro.org, hermit.wangheming@...ilicon.com, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH v2 1/2] dt-bindings: arm: hisilicon: add bindings for hi3798cv200 SoC and Poplar board Am 22.02.2017 um 09:38 schrieb Jiancheng Xue: > Add bindings for HiSilicon hi3798cv200 SoC and Poplar Board. > > Signed-off-by: Jiancheng Xue <xuejiancheng@...ilicon.com> > --- > Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt > index f1c1e21..1fd3dd7 100644 > --- a/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt > +++ b/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt > @@ -4,6 +4,10 @@ Hi3660 SoC > Required root node properties: > - compatible = "hisilicon,hi3660"; > > +Hi3798cv200 Poplar Board > +Required root node properties: > + - compatible = "hisilicon,hi3798cv200-poplar", "hisilicon,hi3798cv200"; Please remember to CC previous reviewers. This still looks wrong: Why is this not "hisilicon,poplar" if you choose against "tocoding,poplar"? Is there a second Poplar board with a different SoC? Even then it would be redundant with the second compatible string. Regards, Andreas > + > Hi4511 Board > Required root node properties: > - compatible = "hisilicon,hi3620-hi4511"; -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
Powered by blists - more mailing lists