linux-kernel - Re: [PATCH v2] mfd: Add Cherrytrail WhiskeyCove PMIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vecem11Fp58+u9dWkA4OJG0UzZakGxzy6YtNpawDsMkGg@mail.gmail.com>
Date:   Tue, 28 Feb 2017 00:06:50 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     Andy Shevchenko <andy@...radead.org>,
        Lee Jones <lee.jones@...aro.org>, Takashi Iwai <tiwai@...e.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bin Gao <bin.gao@...el.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v2] mfd: Add Cherrytrail WhiskeyCove PMIC driver

On Mon, Feb 27, 2017 at 11:38 PM, Hans de Goede <hdegoede@...hat.com> wrote:
> Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non
> upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal
> version which implements just enough to get ACPI PMIC opregion support to
> work, so that suspend/resume will work on machines with this PMIC.
>
> Cc: Bin Gao <bin.gao@...el.com>
> Cc: Felipe Balbi <felipe.balbi@...ux.intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
> Changes in v2:

You were too fast. Please, give a time for reviewers to do their job.

So, please address comments per v2 first.

> -Since this uses plain mfd and not the intel_soc_pmic stuff give it
>  its own Kconfig and allow this to be built as a module

> -Add missing #include <acpi/acpi_bus.h>

Do we need it explicitly included?

-- 
With Best Regards,
Andy Shevchenko