linux-kernel - Re: [PATCH v2] mfd: Add Cherrytrail WhiskeyCove PMIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aff1cc24-819e-0936-2e5f-cdfd452220f0@redhat.com>
Date:   Tue, 28 Feb 2017 14:23:38 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Andy Shevchenko <andy@...radead.org>,
        Lee Jones <lee.jones@...aro.org>, Takashi Iwai <tiwai@...e.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Bin Gao <bin.gao@...el.com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v2] mfd: Add Cherrytrail WhiskeyCove PMIC driver

Hi,

On 27-02-17 23:06, Andy Shevchenko wrote:
> On Mon, Feb 27, 2017 at 11:38 PM, Hans de Goede <hdegoede@...hat.com> wrote:
>> Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non
>> upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal
>> version which implements just enough to get ACPI PMIC opregion support to
>> work, so that suspend/resume will work on machines with this PMIC.
>>
>> Cc: Bin Gao <bin.gao@...el.com>
>> Cc: Felipe Balbi <felipe.balbi@...ux.intel.com>
>> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
>> ---
>> Changes in v2:
>
> You were too fast. Please, give a time for reviewers to do their job.
>
> So, please address comments per v2 first.
>
>> -Since this uses plain mfd and not the intel_soc_pmic stuff give it
>>  its own Kconfig and allow this to be built as a module
>
>> -Add missing #include <acpi/acpi_bus.h>
>
> Do we need it explicitly included?

I was trying to fix a kbuild bot error with this
(Takashi has it on a topic-branch), but it only made it
worse. so I'm dropping this again for v3, instead adding
"depends on ACPI" to the Kconfig for this, which will
hopefully really fix the kbuild bot errors.

Regards,

Hans