linux-kernel - Re: [PATCH v3 1/2] perf/sdt: Introduce util func is_sdt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170228103402.4778ae5ead01aa4a652f4b9e@kernel.org>
Date:   Tue, 28 Feb 2017 10:34:02 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Cc:     mingo@...hat.com, acme@...nel.org, masami.hiramatsu.pt@...achi.com,
        brendan.d.gregg@...il.com, peterz@...radead.org,
        alexander.shishkin@...ux.intel.com, wangnan0@...wei.com,
        jolsa@...nel.org, ak@...ux.intel.com, treeze.taeung@...il.com,
        mathieu.poirier@...aro.org, hekuang@...wei.com,
        sukadev@...ux.vnet.ibm.com, ananth@...ibm.com,
        naveen.n.rao@...ux.vnet.ibm.com, adrian.hunter@...el.com,
        linux-kernel@...r.kernel.org, hemant@...ux.vnet.ibm.com
Subject: Re: [PATCH v3 1/2] perf/sdt: Introduce util func is_sdt_event()

On Fri, 24 Feb 2017 13:13:24 +0530
Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com> wrote:

> No Functionality changes.

Please describe even it seems not have much info.
----
Factor out the SDT event name checking routine as is_sdt_event().
----

BTW, would we really need to move it in util.c? I think parse-event.{c,h}
is a better place.

Thank you,

> 
> Signed-off-by: Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
> ---
>  tools/perf/util/probe-event.c |  9 +--------
>  tools/perf/util/util.c        | 12 ++++++++++++
>  tools/perf/util/util.h        |  2 ++
>  3 files changed, 15 insertions(+), 8 deletions(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 28fb62c..2b1409f 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -1339,14 +1339,7 @@ static int parse_perf_probe_point(char *arg, struct perf_probe_event *pev)
>  	if (!arg)
>  		return -EINVAL;
>  
> -	/*
> -	 * If the probe point starts with '%',
> -	 * or starts with "sdt_" and has a ':' but no '=',
> -	 * then it should be a SDT/cached probe point.
> -	 */
> -	if (arg[0] == '%' ||
> -	    (!strncmp(arg, "sdt_", 4) &&
> -	     !!strchr(arg, ':') && !strchr(arg, '='))) {
> +	if (is_sdt_event(arg)) {
>  		pev->sdt = true;
>  		if (arg[0] == '%')
>  			arg++;
> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> index d8b45ce..b827428 100644
> --- a/tools/perf/util/util.c
> +++ b/tools/perf/util/util.c
> @@ -802,3 +802,15 @@ int unit_number__scnprintf(char *buf, size_t size, u64 n)
>  
>  	return scnprintf(buf, size, "%" PRIu64 "%c", n, unit[i]);
>  }
> +
> +/*
> + * If the probe point starts with '%',
> + * or starts with "sdt_" and has a ':' but no '=',
> + * then it should be a SDT/cached probe point.
> + */
> +bool is_sdt_event(char *str)
> +{
> +	return (str[0] == '%' ||
> +		(!strncmp(str, "sdt_", 4) &&
> +		 !!strchr(str, ':') && !strchr(str, '=')));
> +}
> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
> index c74708d..ee599dc 100644
> --- a/tools/perf/util/util.h
> +++ b/tools/perf/util/util.h
> @@ -364,4 +364,6 @@ int is_printable_array(char *p, unsigned int len);
>  int timestamp__scnprintf_usec(u64 timestamp, char *buf, size_t sz);
>  
>  int unit_number__scnprintf(char *buf, size_t size, u64 n);
> +
> +bool is_sdt_event(char *str);
>  #endif /* GIT_COMPAT_UTIL_H */
> -- 
> 2.9.3
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>