linux-kernel - Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACna6rw1oeUn=QuD-c+X8uokypSEqXUP3yqmiMEK2wgMD-ENeQ@mail.gmail.com>
Date:   Tue, 28 Feb 2017 21:43:09 +0100
From:   Rafał Miłecki <zajec5@...il.com>
To:     Jon Mason <jon.mason@...adcom.com>
Cc:     Hauke Mehrtens <hauke@...ke-m.de>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Jon Mason <jonmason@...adcom.com>
Subject: Re: [PATCH 1/2] ARM: dts: bcm5301x: Add TWD WD Support to DT

On 28 February 2017 at 21:31, Jon Mason <jon.mason@...adcom.com> wrote:
> @@ -70,10 +70,19 @@
>                         clocks = <&periph_clk>;
>                 };
>
> -               local-timer@...00 {
> +               timer@...00 {

Is there a reason for this rename? I don't really have preference for
any name, it's just we shouldn't keep renaming this depending of
personal preferences.

It also doesn't seem like adjusting to any schema:
bcm63138.dtsi uses local-timer@...00
bcm-nsp.dtsi uses twd-timer@...00
berlin2cd.dtsi uses local-timer@...600
berlin2.dtsi uses local-timer@...600
berlin2q.dtsi uses local-timer@...600


>                         compatible = "arm,cortex-a9-twd-timer";
> -                       reg = <0x20600 0x100>;
> -                       interrupts = <GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH>;
> +                       reg = <0x20600 0x20>;
> +                       interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(2) |
> +                                                 IRQ_TYPE_LEVEL_HIGH)>;
> +                       clocks = <&periph_clk>;
> +               };

The rest looks OK, thanks! :)

-- 
Rafał