linux-kernel - Re: [PATCH] tpm: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A83F6A3E-1BE9-48C9-8FB8-B3C061402061@gmx.de>
Date:   Tue, 28 Feb 2017 22:24:45 +0100
From:   Peter Huewe <peterhuewe@....de>
To:     Arnd Bergmann <arnd@...db.de>,
        Marcel Selhorst <tpmdd@...horst.net>,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
CC:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        Christophe Ricard <christophe.ricard@...il.com>,
        Nayna Jain <nayna@...ux.vnet.ibm.com>,
        tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm: select CONFIG_CRYPTO



Am 28. Februar 2017 22:12:55 MEZ schrieb Arnd Bergmann <arnd@...db.de>:
>We get a newly introduced harmless warning when CONFIG_CRYPTO is
>disabled:
>
>warning: (TCG_TPM && TRUSTED_KEYS && IMA) selects CRYPTO_HASH_INFO
>which has unmet direct dependencies (CRYPTO)
>
>This adds another select to avoid the warning, consistent with other
>users
>of the crypto code.
>
>Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support
>multiple banks")
>Signed-off-by: Arnd Bergmann <arnd@...db.de>
Lgtm

Reviewed-by: Peter Huewe <peterhuewe@....de>
>---
> drivers/char/tpm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
>index af985cca413c..d520ac51c11c 100644
>--- a/drivers/char/tpm/Kconfig
>+++ b/drivers/char/tpm/Kconfig
>@@ -6,6 +6,7 @@ menuconfig TCG_TPM
> 	tristate "TPM Hardware Support"
> 	depends on HAS_IOMEM
> 	select SECURITYFS
>+	select CRYPTO
> 	select CRYPTO_HASH_INFO
> 	---help---
> 	  If you have a TPM security chip in your system, which

-- 
Sent from my mobile