linux-kernel - Re: [PATCH] pci: dwc: Fix NULL pointer dereference due to missing assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170228210231.GB29859@bhelgaas-glaptop.roam.corp.google.com>
Date:   Tue, 28 Feb 2017 15:02:31 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>
Cc:     bhelgaas@...gle.com, Guenter Roeck <linux@...ck-us.net>,
        Kishon Vijay Abraham I <kishon@...com>,
        Jingoo Han <jingoohan1@...il.com>,
        Joao Pinto <Joao.Pinto@...opsys.com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pci: dwc: Fix NULL pointer dereference due to missing
 assignment

On Tue, Feb 28, 2017 at 01:38:18PM +0530, Vivek Gautam wrote:
> Add missing assignment of dw_pci core structure for
> designware-plat.
> 
> Commit 8b130f815a6b ("PCI: dwc: Fix crashes seen due to missing
> assignments") fixed all other platforms, but missed
> designware-plat file.
> 
> Fixes: 442ec4c04d12 ("PCI: dwc: all: Split struct pcie_port into host-only and core structures")
> 
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Kishon Vijay Abraham I <kishon@...com>
> Cc: Jingoo Han <jingoohan1@...il.com>
> Cc: Joao Pinto <Joao.Pinto@...opsys.com>
> Cc: linux-pci@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Vivek Gautam <vivek.gautam@...eaurora.org>

Thanks, Vivek!  I folded this into Guenter's patch and added your
Signed-off-by for this designware-plat fix.  I'll ask Linus to pull this
before v4.11-rc1.

> ---
> 
> Based on torvald's master branch.
> Build tested.
> 
>  drivers/pci/dwc/pcie-designware-plat.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/dwc/pcie-designware-plat.c b/drivers/pci/dwc/pcie-designware-plat.c
> index 65250f63515c..b6c832ba39dd 100644
> --- a/drivers/pci/dwc/pcie-designware-plat.c
> +++ b/drivers/pci/dwc/pcie-designware-plat.c
> @@ -104,6 +104,8 @@ static int dw_plat_pcie_probe(struct platform_device *pdev)
>  
>  	pci->dev = dev;
>  
> +	dw_plat_pcie->pci = pci;
> +
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	pci->dbi_base = devm_ioremap_resource(dev, res);
>  	if (IS_ERR(pci->dbi_base))
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>