linux-kernel - Re: [PATCH v2] staging: iio: accel: Move header file content to source file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALrZqyMXWEgR6seOHBgVL+cS7jPmPAGvyiWjFSrTmR5t9yhwtA@mail.gmail.com>
Date:   Wed, 1 Mar 2017 01:07:18 +0530
From:   SIMRAN SINGHAL <singhalsimran0@...il.com>
To:     Lars-Peter Clausen <lars@...afoo.de>
Cc:     Jonathan Cameron <jic23@...nel.org>, Michael.Hennerich@...log.com,
        knaack.h@....de, Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Greg KH <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        devel@...verdev.osuosl.org, outreachy-kernel@...glegroups.com
Subject: Re: [PATCH v2] staging: iio: accel: Move header file content to
 source file

On Wed, Mar 1, 2017 at 1:04 AM, Lars-Peter Clausen <lars@...afoo.de> wrote:
> On 02/28/2017 08:32 PM, SIMRAN SINGHAL wrote:
>> On Wed, Mar 1, 2017 at 12:53 AM, Jonathan Cameron <jic23@...nel.org> wrote:
>>> On 28/02/17 19:17, Jonathan Cameron wrote:
>>>> On 28/02/17 18:51, simran singhal wrote:
>>>>> The contents of the header file are used only by this single
>>>>> source file. Move content into .c and remove .h.
>>>>>
>>>>> Signed-off-by: simran singhal <singhalsimran0@...il.com>
>>>> Applied to the togreg branch of iio.git and pushed out as testing
>>>> for the autobuilders to play with it.
>>>>
>>>> Thanks,
>>>>
>>>> Jonathan
>>>
>>> One quick note:
>>>
>>> The title should include the name of the driver being modified
>>> as this is probably the bit interested people are most likely
>>> to pick up on in a long list of patches.
>>>
>>> I fixed this up.  Thanks,
>>>
>>> Jonathan
>>
>> I have included the name of driver being modified.
>> Due to want me to include the name of file i.e adis16201_core.c
>
> Not the full filename, but the partnumber. E.g.
>
>         'staging: iio: adis16201: ...'
>

Lars-Peter, I got it.

Jonathan, I got my mistake should I send v3.