linux-kernel - Re: [GIT PULL] HID for 4.11

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06556567-7a6a-5d40-ce4a-1c408956e51e@synaptics.com>
Date:   Tue, 28 Feb 2017 23:43:08 -0800
From:   Andrew Duggan <aduggan@...aptics.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Peter Hutterer <peter.hutterer@...-t.net>
CC:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Subject: Re: [GIT PULL] HID for 4.11


On 02/28/2017 09:05 PM, Linus Torvalds wrote:
> On Tue, Feb 28, 2017 at 7:24 PM, Peter Hutterer
> <peter.hutterer@...-t.net> wrote:
>> I suspect you're just triggering a bug that wasn't triggered by the ps/2
>> emulation. you can run linput-debug-events --verbose and have a look at the
>> various state debugging information, that may hint at what's going on (e.g.
>> a finger mistaken as palm touch, or something). Or record one such
>> interaction with evemu-record and send it to me (preferrably here [1], if
>> you're using libinput). Also, what version of libinput/synaptics are you on?
> bug reported (it's bug 100014).
>
> This is libinput-1.5.4 on Fedora 24. I attached both the
> libinput-debug-events output as well as evemu-report output, which
> hopefully fills in all the details.
>
>                   Linus

Actually, it looks like this is a regression which was introduced by 
bf3e8502eefd ("Input: synaptics-rmi4 - clean up F30 implementation"). 
 From the bug report I noticed that the INPUT_PROP_BUTTONPAD property 
was not set for the touchpad. The previous behavior was to set 
INPUT_PROP_BUTTONPAD if F30 detected only one valid button (or if there 
was a flag in the platform data). But, now INPUT_PROP_BUTTONPAD is not 
being set and libinput does not know that the touchpad is a clickpad. 
After updating I was able to reproduce the issue with bf3e8502eefd applied.

Andrew