linux-kernel - Re: [PATCH v2 4/4] acpi: Move the verification of duplicate proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1703011212450.4005@nanos>
Date:   Wed, 1 Mar 2017 12:26:36 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Dou Liyang <douly.fnst@...fujitsu.com>
cc:     mingo@...nel.org, peterz@...radead.org, rjw@...ysocki.net,
        hpa@...or.com, rafael@...nel.org, cl@...ux.com, tj@...nel.org,
        akpm@...ux-foundation.org, rafael.j.wysocki@...el.com,
        len.brown@...el.com, izumi.taku@...fujitsu.com,
        xiaolong.ye@...el.com, x86@...nel.org, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] acpi: Move the verification of duplicate proc_id
 from booting time to hot-plug time

On Mon, 20 Feb 2017, Dou Liyang wrote:

Please make your subject line short and a precise summary phrase, not an
overlong sentence.

> After we revert the the mapping of "cpuid <-> nodeid" fixed at the
> booting time. and do it at the hot-plug time. we should also do the
> verification of duplicate proc_id at the time.

The revert is completely irrelevant to this change, really. The reference
is just confusing.

> The patch rename the verfication function and move it to
> drivers/acpi::acpi_processor_get_info.

See previous mails ....

Let me give you another changelog example:

Subject: acpi/processor: Check for duplicate processor ids at hotplug time

  The check for duplicate processor ids happens at boot time based on the
  ACPI table contents, but the final sanity checks for a processor happen
  at hotplug time.

  At hotplug time, where the physical information is available, which might
  differ from the ACPI table information, a check for duplicate processor
  ids is missing.

  Add it to the hotplug checks and rename the function so it better
  reflects its purpose.

Hmm?

>  
> -bool __init acpi_processor_validate_proc_id(int proc_id)
> +bool duplicate_processor_id(int proc_id)

Please keep the acpi_ prefix. acpi_duplicate_processor_id().

Thanks,

	tglx