linux-kernel - Re: [PATCH] objtool, module: discard _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9593504E-702C-4ABC-A72A-FAF77999B707@zytor.com>
Date:   Wed, 01 Mar 2017 08:44:38 -0800
From:   hpa@...or.com
To:     Josh Poimboeuf <jpoimboe@...hat.com>,
        Ingo Molnar <mingo@...nel.org>
CC:     linux-kernel@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jessica Yu <jeyu@...hat.com>
Subject: Re: [PATCH] objtool, module: discard __unreachable section for modules

On March 1, 2017 7:20:03 AM PST, Josh Poimboeuf <jpoimboe@...hat.com> wrote:
>The __unreachable section is only used at compile time.  It's discarded
>for vmlinux but it should also be discarded for modules.
>
>Fixes: d1091c7fa3d5 ("objtool: Improve detection of BUG() and other
>dead ends")
>Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>
>---
> scripts/module-common.lds | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/scripts/module-common.lds b/scripts/module-common.lds
>index 73a2c7d..936a3c6 100644
>--- a/scripts/module-common.lds
>+++ b/scripts/module-common.lds
>@@ -4,7 +4,10 @@
>  * combine them automatically.
>  */
> SECTIONS {
>-	/DISCARD/ : { *(.discard) }
>+	/DISCARD/ : {
>+		*(.discard)
>+		*(__unreachable)
>+	}
> 
> 	__ksymtab		0 : { *(SORT(___ksymtab+*)) }
> 	__ksymtab_gpl		0 : { *(SORT(___ksymtab_gpl+*)) }

I would like to see a name like, say, ".annot.unreachable", since is odds are pretty high we are going to need more annotations in the future.
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.