linux-kernel - Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Mar 2017 15:10:53 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Jaejoong Kim <climbbb.kim@...il.com>
Cc:     jikos@...nel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct
 hid_device to hiddev

On Mar 02 2017 or thereabouts, Jaejoong Kim wrote:
> We need to store the minor number each drivers. In case of hidraw, it's
> minor number stores in struct hidraw. But hiddev's minor is located in
> struct hid_device.
> 
> So reallocates for hiddev's minor number.
> 

There is not a real need to have this one in a separate patch. Also, it
depends on the patch "[PATCH] HID: cp2112: use proper hidraw name with
minor number", so better include this cp2112 in this series (as I
mentioned in the cp2112 patch).

I'd say simply squash this patch with 2/2 and have the cp2112 as 1/2.

Cheers,
Benjamin

> Signed-off-by: Jaejoong Kim <climbbb.kim@...il.com>
> ---
>  drivers/hid/usbhid/hiddev.c | 1 +
>  include/linux/hid.h         | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
> index 700145b..5c2c489 100644
> --- a/drivers/hid/usbhid/hiddev.c
> +++ b/drivers/hid/usbhid/hiddev.c
> @@ -47,6 +47,7 @@
>  #define HIDDEV_BUFFER_SIZE	2048
>  
>  struct hiddev {
> +	int minor;
>  	int exist;
>  	int open;
>  	struct mutex existancelock;
> diff --git a/include/linux/hid.h b/include/linux/hid.h
> index 28f38e2b8..643c017 100644
> --- a/include/linux/hid.h
> +++ b/include/linux/hid.h
> @@ -541,7 +541,6 @@ struct hid_device {							/* device report descriptor */
>  	struct list_head inputs;					/* The list of inputs */
>  	void *hiddev;							/* The hiddev structure */
>  	void *hidraw;
> -	int minor;							/* Hiddev minor number */
>  
>  	int open;							/* is the device open by anyone? */
>  	char name[128];							/* Device name */
> -- 
> 2.7.4
>