linux-kernel - Re: [PATCH] bcache: Fix bcache device names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bbc24f07-64c7-2095-f2ba-877016070175@coly.li>
Date:   Thu, 2 Mar 2017 22:11:23 +0800
From:   Coly Li <i@...y.li>
To:     Stefan Bader <stefan.bader@...onical.com>,
        linux-bcache@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Eric Wheeler <bcache@...ux.ewheeler.net>
Subject: Re: [PATCH] bcache: Fix bcache device names

On 2017/3/2 下午7:11, Stefan Bader wrote:
> When adding partition support to bcache, the name assignment was not
> updated, resulting in numbers jumping (bcache0, bcache16, bcache32...).
> Fix this by taking BCACHE_MINORS into account when assigning the disk
> name.
> 
> BugLink: https://bugs.launchpad.net/bugs/1667078
> 
> Fixes: b8c0d91 (bcache: partition support: add 16 minors per bcacheN device)
> Cc: <stable@...r.kernel.org> # v4.10
> Signed-off-by: Stefan Bader <stefan.bader@...onical.com>

Acked-by: Coly Li <colyli@...e.de>

> ---
>  drivers/md/bcache/super.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 85e3f21..817e155 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -793,7 +793,8 @@ static int bcache_device_init(struct bcache_device *d, unsigned block_size,
>  	}
>  
>  	set_capacity(d->disk, sectors);
> -	snprintf(d->disk->disk_name, DISK_NAME_LEN, "bcache%i", minor);
> +	snprintf(d->disk->disk_name, DISK_NAME_LEN, "bcache%i",
> +		 minor / BCACHE_MINORS);
>  
>  	d->disk->major		= bcache_major;
>  	d->disk->first_minor	= minor;
>