linux-kernel - Re: [patch 1/3] speakup: extend synth buffer to 16bit unicode characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y3wmjjbx.fsf@the-brannons.com>
Date:   Fri, 03 Mar 2017 10:39:30 -0800
From:   Chris Brannon <chris@...-brannons.com>
To:     Samuel Thibault <samuel.thibault@...-lyon.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kirk Reiser <kirk@...sers.ca>,
        William Hubbs <w.d.hubbs@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        speakup@...ux-speakup.org
Subject: Re: [patch 1/3] speakup: extend synth buffer to 16bit unicode characters

Samuel Thibault <samuel.thibault@...-lyon.org> writes:

> This extends the synth buffer slots to 16bit, so as to hold 16bit
> unicode characters.
>
> synth_buffer_getc and synth_buffer_peek now return 16bit characters.
> Speech synthesizers which do not support characters beyond latin1 can
> use the synth_buffer_skip_nonlatin1() helper to skip the non-latin1
> characters before getting or peeking. All synthesizers are made to use
> it for now.
>
> This makes synth_buffer_add take a 16bit character. For simplicity for
> now, synth_printf is left to using latin1 formats and strings.
> synth_putwc, synth_putwc_s, synth_putws and synth_putws_s helpers are
> however added to put 16bit characters and strings.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>


Reviewed-by: Chris Brannon <chris@...-brannons.com>


Looks good to me.