linux-kernel - Re: [PATCH 02/10] perf, tools, stat: Collapse identically named events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170305175542.GC20686@krava>
Date:   Sun, 5 Mar 2017 18:55:42 +0100
From:   Jiri Olsa <jolsa@...hat.com>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     acme@...nel.org, jolsa@...nel.org, linux-kernel@...r.kernel.org,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 02/10] perf, tools, stat: Collapse identically named
 events

On Tue, Feb 28, 2017 at 10:49:16PM -0800, Andi Kleen wrote:

SNIP

>  
>  struct aggr_data {
> @@ -1208,6 +1231,16 @@ static void aggr_cb(struct perf_evsel *counter, void *data, bool first)
>  		if (first)
>  			ad->nr++;
>  		counts = perf_counts(counter->counts, cpu, 0);
> +		/*
> +		 * When any result is bad, make them all to give
> +		 * consistent output in interval mode.
> +		 */
> +		if (counts->ena == 0 || counts->run == 0 ||
> +		    counter->counts->scaled == -1) {
> +			ad->ena = 0;
> +			ad->run = 0;
> +			break;
> +		}

I think this needs to be in separate patch, showing
the interval output before and after the change..

thanks,
jirka