linux-kernel - Re: [PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

Open Source and information security mailing list archives

Message-ID: <alpine.LFD.2.20.1703050050140.10898@casper.infradead.org>
Date:   Sun, 5 Mar 2017 00:51:33 +0000 (GMT)
From:   James Simmons <jsimmons@...radead.org>
To:     simran singhal <singhalsimran0@...il.com>
cc:     Larry.Finger@...inger.net, devel@...verdev.osuosl.org,
        florian.c.schilhabel@...glemail.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, oleg.drokin@...el.com,
        outreachy-kernel@...glegroups.com
Subject: Re: [PATCH v5 3/5] staging: lustre: lustre: Remove unnecessary cast
 on void pointer


> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> |
>   ((T *)x)[...]
> |
>   ((T*)x)->f
> |
> - (T*)
>   e
> )
> 
> Signed-off-by: simran singhal <singhalsimran0@...il.com>

Reviewed-by: James Simmons <jsimmons@...radead.org>

> ---
> 
>  v5:
>    -Fixed compilation warnings.
> 
>  drivers/staging/lustre/lustre/llite/range_lock.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/range_lock.c b/drivers/staging/lustre/lustre/llite/range_lock.c
> index 14148a0..161391b 100644
> --- a/drivers/staging/lustre/lustre/llite/range_lock.c
> +++ b/drivers/staging/lustre/lustre/llite/range_lock.c
> @@ -174,7 +174,7 @@ void range_unlock(struct range_lock_tree *tree, struct range_lock *lock)
>   */
>  static enum interval_iter range_lock_cb(struct interval_node *node, void *arg)
>  {
> -	struct range_lock *lock = (struct range_lock *)arg;
> +	struct range_lock *lock = arg;
>  	struct range_lock *overlap = node2rangelock(node);
>  
>  	lock->rl_blocking_ranges += overlap->rl_lock_count + 1;
> -- 
> 2.7.4
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives