linux-kernel - Re: [PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void pointer

Open Source and information security mailing list archives

Date:   Sun, 5 Mar 2017 00:51:59 +0000 (GMT)
From:   James Simmons <jsimmons@...radead.org>
To:     simran singhal <singhalsimran0@...il.com>
cc:     Larry.Finger@...inger.net, devel@...verdev.osuosl.org,
        florian.c.schilhabel@...glemail.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, oleg.drokin@...el.com,
        outreachy-kernel@...glegroups.com
Subject: Re: [PATCH v5 2/5] staging: lustre: Remove unnecessary cast on void
 pointer


> The following Coccinelle script was used to detect this:
> @r@
> expression x;
> void* e;
> type T;
> identifier f;
> @@
> (
>   *((T *)e)
> |
>   ((T *)x)[...]
> |
>   ((T*)x)->f
> |
> - (T*)
>   e
> )
> 
> Signed-off-by: simran singhal <singhalsimran0@...il.com>

Reviewed-by: James Simmons <jsimmons@...radead.org>

> ---
>  drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> index 271e189..09b46924 100644
> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
> @@ -640,7 +640,7 @@ static int lmv_fid2path(struct obd_export *exp, int len, void *karg,
>  	int			remote_gf_size = 0;
>  	int			rc;
>  
> -	gf = (struct getinfo_fid2path *)karg;
> +	gf = karg;
>  	tgt = lmv_find_target(lmv, &gf->gf_fid);
>  	if (IS_ERR(tgt))
>  		return PTR_ERR(tgt);
> @@ -657,7 +657,7 @@ static int lmv_fid2path(struct obd_export *exp, int len, void *karg,
>  		struct getinfo_fid2path *ori_gf;
>  		char *ptr;
>  
> -		ori_gf = (struct getinfo_fid2path *)karg;
> +		ori_gf = karg;
>  		if (strlen(ori_gf->gf_path) +
>  		    strlen(gf->gf_path) > ori_gf->gf_pathlen) {
>  			rc = -EOVERFLOW;
> -- 
> 2.7.4
> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives