linux-kernel - Re: [PATCH v2] Input: sparse-keymap - use a managed allocation for keymap copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VftVMeCgLBSR0DySG2frf3bX26=k28uPchzB1F7MH6jjw@mail.gmail.com>
Date:   Mon, 6 Mar 2017 09:39:58 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Michał Kępień <kernel@...pniu.pl>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Input: sparse-keymap - use a managed allocation for
 keymap copy

On Mon, Mar 6, 2017 at 9:09 AM, Michał Kępień <kernel@...pniu.pl> wrote:
>> On Thu, Mar 2, 2017 at 2:02 PM, Michał Kępień <kernel@...pniu.pl> wrote:

>> > + * Since sparse_keymap_setup() now uses a managed allocation for the
>> > + * keymap copy, use of this function is deprecated.
>>
>> So...
>>
>> >   */
>> >  void sparse_keymap_free(struct input_dev *dev)
>>
>> ... add __deprecated then?
>
> Sure, I can do that if Dmitry recognizes this patch as otherwise sane.
> I have never used that attribute before, so thanks for the tip.

It will provoke a warning when compiling the code.
It makes sense if anyone is going to fix the current users and leave
old API for one cycle.

So, the question is what we are going to do with an old API.

-- 
With Best Regards,
Andy Shevchenko