linux-kernel - Re: [PATCH] HID: hid-multitouch: change for touch height/width

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1703061448270.31814@cbobk.fhfr.pm>
Date:   Mon, 6 Mar 2017 14:48:59 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     HungNien Chen <hn.chen@...dahitech.com>
cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        dmitry.torokhov@...il.com, jonathan.a.clarke@...il.com,
        benjamin.tissoires@...hat.com
Subject: Re: [PATCH] HID: hid-multitouch: change for touch height/width

On Mon, 6 Mar 2017, hn.chen@...dahitech.com wrote:

> From: HungNien Chen <hn.chen@...dahitech.com>
> 
> Just quote from Jonathan Clarke in previous thread(2017/01/24):
> "This division by 2 was added along with the touch width/height
> fields 6 years ago so that those fields 'match the visual scale
> of the touch' for a specific device (3M PCT)"
> "The scaling is also discarding information about touch size
> (1 bit for each of width/height) which is useful for any
> application that wants to know about it."
> 
> Jonathan mentioned just what I thought in a new project recently.
> It dosen't make sense to discard 1 bit width/height in general
> case according to the spec in multi-touch-protocol.txt so
> I would like to make a slight change here.
> 
> A quirk MT_QUIRK_TOUCH_SIZE_SCALING was added to service
> devices like 3M PCT with a special visual scale and
> the division by 2 only take effect with devices like that.

I've reformatted the changelog a bit and applied to for-4.12/multitouch. 
Thanks,

-- 
Jiri Kosina
SUSE Labs