linux-kernel - Re: block/sed-opal.c: 2 * bad if tests ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9b98f762-ca72-1f6a-6f28-d42138389df7@intel.com>
Date:   Mon, 6 Mar 2017 08:19:33 -0700
From:   Jon Derrick <jonathan.derrick@...el.com>
To:     David Binderman <dcb314@...mail.com>,
        "scott.bauer@...el.com" <scott.bauer@...el.com>,
        "rafael.antognolli@...el.com" <rafael.antognolli@...el.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: block/sed-opal.c: 2 * bad if tests ?

On 03/06/2017 05:00 AM, David Binderman wrote:
> Hello there,
> 
> 1.
> 
> block/sed-opal.c:2136:40: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]
> 
> Source code is
> 
>     if (lk_unlk->session.who < OPAL_USER1 &&
>         lk_unlk->session.who > OPAL_USER9) {
> 
> 2.
> 
> block/sed-opal.c:2319:37: warning: logical ‘and’ of mutually exclusive tests is always false [-Wlogical-op]
> 
>     if (opal_session->who < OPAL_USER1 &&
>         opal_session->who > OPAL_USER9) {
> 
> Duplicate.
> 
> Also in the same file:
> 
> [block/sed-opal.c:1034]: (style) Variable 'method' is assigned a value that is never used.
> 
> Regards
> 
> David Binderman
> 
Thanks for the catch(es). Will provide patch shortly