linux-kernel - Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Mar 2017 10:31:36 +0000
From:   James Hogan <james.hogan@...tec.com>
To:     Guenter Roeck <linux@...ck-us.net>
CC:     Ralf Baechle <ralf@...ux-mips.org>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        <linux-mips@...ux-mips.org>, <linux-kernel@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH v3] MIPS: Fix build breakage caused by header file changes

Hi Guenter,

On Tue, Mar 07, 2017 at 09:33:40AM +0000, James Hogan wrote:
> On Mon, Mar 06, 2017 at 07:30:05PM -0800, Guenter Roeck wrote:
> > On 03/06/2017 03:20 PM, James Hogan wrote:
> > > On Mon, Mar 06, 2017 at 11:13:55AM -0800, Guenter Roeck wrote:
> > >> Since commit f3ac60671954 ("sched/headers: Move task-stack related
> > >> APIs from <linux/sched.h> to <linux/sched/task_stack.h>") and commit
> > >> f780d89a0e82 ("sched/headers: Remove <asm/ptrace.h> from
> > >> <linux/sched.h>"), various mips builds fail as follows.
> > >>
> > >> arch/mips/kernel/smp-mt.c: In function ‘vsmp_boot_secondary’:
> > >> arch/mips/include/asm/processor.h:384:41: error:
> > >> 	implicit declaration of function ‘task_stack_page’
> > >>
> > >> In file included from
> > >> 	/opt/buildbot/slave/hwmon-testing/build/arch/mips/kernel/pm.c:
> > >> arch/mips/include/asm/fpu.h: In function '__own_fpu':
> > >> arch/mips/include/asm/processor.h:385:31: error:
> > >> 	invalid application of 'sizeof' to incomplete type 'struct pt_regs'
> > >
> > > This one is in an inline function, so I think it'd affect multiple
> > > includes of <asm/fpu.h> even if __own_fpu isn't used, so I think the
> > > following patch which adds the include ptrace.h in fpu.h is more robust
> > > than adding to the individual c files affected:
> > > https://patchwork.linux-mips.org/patch/15386/
> > >
> > Agreed.
> > 
> > > Admitedly it could probably have a more specific subject line since
> > > there are more similar errors.
> > 
> > Does that fix all compile problems ? Seems to me that we'll still need
> > 
> > -#include <linux/sched.h>
> > +#include <linux/sched/task_stack.h>
> > 
> > or did you prepare a patch for this as well ?
> 
> It fixed the config I was using at the time. I didn't do a full build
> test of all configs at the time so didn't fix the above.

More specifically your changes to the following files:
arch/mips/kernel/pm.c
arch/mips/power/cpu.c

Don't appear to be necessary with my patch above, but the rest look good
to me. With those changes removed:

Reviewed-by: James Hogan <james.hogan@...tec.com>

Build testing of that in progress...

Thanks
James

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)