linux-kernel - Re: [xfrm] xfrm: Added the auth and enc update support in "state update"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170307102053.GJ694@gauss.secunet.com>
Date:   Tue, 7 Mar 2017 11:20:53 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     <trajaraman@...sta.com>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [xfrm] xfrm: Added the auth and enc update support in "state
 update"

On Fri, Mar 03, 2017 at 03:53:39PM +0530, trajaraman@...sta.com wrote:
> From: Thiruvadi rajaraman <trajaraman@...sta.com>
> 
> Updated the xfrm state update process to update the
> Authendication and Encryption keys.
> 
> Signed-off-by: Thiruvadi rajaraman <trajaraman@...sta.com>
> ---
>  net/xfrm/xfrm_state.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
> index 419bf5d..6b15447 100644
> --- a/net/xfrm/xfrm_state.c
> +++ b/net/xfrm/xfrm_state.c
> @@ -1388,6 +1388,12 @@ int xfrm_state_update(struct xfrm_state *x)
>  		memcpy(&x1->lft, &x->lft, sizeof(x1->lft));
>  		x1->km.dying = 0;
>  
> +		/* To update Authendication and Encryption keys */
> +		x1->aalg = kmemdup(x->aalg, xfrm_alg_auth_len(x->aalg),
> +								GFP_KERNEL);
> +		x1->ealg = kmemdup(x->ealg, xfrm_alg_len(x->ealg),
> +								GFP_KERNEL);

Please explain why you need this and which bug it fixes.
Please write this into the commit message. The commit
message should explain why this change is needed in the
first place. Also please align you patch to common coding
style.

Thanks!