linux-kernel - Re: [PATCH] mtd: nand: fix write accessor sanity checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAQ8GrGEKGArRC2+xh_JDuFjrd-wQG3kKu80-GMuXRvvBA@mail.gmail.com>
Date:   Tue, 7 Mar 2017 22:03:03 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:     linux-mtd@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Marek Vasut <marek.vasut@...il.com>,
        Brian Norris <computersforpeace@...il.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>
Subject: Re: [PATCH] mtd: nand: fix write accessor sanity checks

Hi Boris,


2017-03-07 20:40 GMT+09:00 Boris Brezillon <boris.brezillon@...e-electrons.com>:
> On Tue,  7 Mar 2017 20:23:59 +0900
> Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
>
>> If the higher level accessor chip->write_page() is implemented,
>> ecc->write_page() and ecc->write_page_raw() are not required.
>
> I'm about to remove the chip->write_page() hook [1], I hope you're not
> planning to use it.
>
> [1]https://patchwork.ozlabs.org/patch/729966/
>

In fact, I was wondering if I should use chip->write_page()
for denali.c  (then I noticed this broken accessor checks).
After all, I decided to not (ab)use chip->write_page(), though.

Anyway, it is good that I am sure about this now.

Thanks!

-- 
Best Regards
Masahiro Yamada