linux-kernel - [PATCH v1] locking/ww_mutex: Prevent read of uninitialized memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue,  7 Mar 2017 11:54:40 -0500
From:   Robert Foss <robert.foss@...labora.com>
To:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org
Cc:     Robert Foss <robert.foss@...labora.com>
Subject: [PATCH v1] locking/ww_mutex: Prevent read of uninitialized memory

abba.result is potentially uninitialized, but read during one
error condition.

On "missed ABBA deadlock" abba.result is read, but not initialized
in all situations.

Detected by CoverityScan, CID#1402035 ("Uninitialized scalar variable")

Signed-off-by: Robert Foss <robert.foss@...labora.com>
---
 kernel/locking/test-ww_mutex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c
index da6c9a34f62f..d11ad012bae6 100644
--- a/kernel/locking/test-ww_mutex.c
+++ b/kernel/locking/test-ww_mutex.c
@@ -196,7 +196,7 @@ static void test_abba_work(struct work_struct *work)
 
 static int test_abba(bool resolve)
 {
-	struct test_abba abba;
+	struct test_abba abba = { 0 };
 	struct ww_acquire_ctx ctx;
 	int err, ret;
 
-- 
2.11.0.453.g787f75f05