linux-kernel - [PATCH v2] genirq: Add support for nested shared IRQs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Mar 2017 16:28:18 +0000
From:   Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
To:     <tglx@...utronix.de>
CC:     <linux-kernel@...r.kernel.org>,
        <patches@...nsource.wolfsonmicro.com>
Subject: [PATCH v2] genirq: Add support for nested shared IRQs

I am working on a system which has an audio CODEC and two speaker amps,
each of the speaker amps have an open-drain IRQ line which are connected
together and attached to a pin on the audio CODEC, which is capable of
functioning as an IRQ chip. The audio CODEC then in turn has its own IRQ
line which heads back to the host processor.

This setup necessitates having a shared nested IRQ on the audio CODEC.
Currently however the kernel does not appear to support shared nested
IRQs.

Fortunately support is fairly easy to add, only required the
modification of handle_nested_irq to call all the IRQ handlers, rather
than just the first one associated with the IRQ.

Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>
---

Changes since v1:
 - Improve commit messages
 - Use for_each_action_of_desc
 - Correct handling of note_interrupt

Thanks,
Charles

 kernel/irq/chip.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index be3c34e..686be4b 100644
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -348,7 +348,10 @@ void handle_nested_irq(unsigned int irq)
 	irqd_set(&desc->irq_data, IRQD_IRQ_INPROGRESS);
 	raw_spin_unlock_irq(&desc->lock);

-	action_ret = action->thread_fn(action->irq, action->dev_id);
+	action_ret = IRQ_NONE;
+	for_each_action_of_desc(desc, action)
+		action_ret |= action->thread_fn(action->irq, action->dev_id);
+
 	if (!noirqdebug)
 		note_interrupt(desc, action_ret);

-- 
2.1.4