linux-kernel - Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Mar 2017 10:43:08 +0100
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Cc:     acme@...nel.org, peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] perf probe: Remove stale func add_perf_probe_events

On Wed,  8 Mar 2017 12:29:08 +0530
Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com> wrote:

> I don't see any user of this function. This function was being copied
> to tools/perf/builtin-probe.c by commit b02137cc6550 ("perf probe: Move
> print logic into cmd_probe()"). Since then it has became stale.

Hmm, I have intended to keep it as an library API, which allows 
user to add event silently (e.g. adding sdt event in background).

Thanks,

> 
> Signed-off-by: Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
> ---
>  tools/perf/util/probe-event.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 4f9d6ee..9f18204 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -3361,24 +3361,6 @@ void cleanup_perf_probe_events(struct perf_probe_event *pevs, int npevs)
>  	}
>  }
>  
> -int add_perf_probe_events(struct perf_probe_event *pevs, int npevs)
> -{
> -	int ret;
> -
> -	ret = init_probe_symbol_maps(pevs->uprobes);
> -	if (ret < 0)
> -		return ret;
> -
> -	ret = convert_perf_probe_events(pevs, npevs);
> -	if (ret == 0)
> -		ret = apply_perf_probe_events(pevs, npevs);
> -
> -	cleanup_perf_probe_events(pevs, npevs);
> -
> -	exit_probe_symbol_maps();
> -	return ret;
> -}
> -
>  int del_perf_probe_events(struct strfilter *filter)
>  {
>  	int ret, ret2, ufd = -1, kfd = -1;
> -- 
> 2.9.3
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>