linux-kernel - Re: [PATCH 2/2] iproute2: add support for invisible qdisc dumping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1703081138180.31814@cbobk.fhfr.pm>
Date:   Wed, 8 Mar 2017 11:40:19 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Phil Sutter <phil@....cc>
cc:     "David S. Miller" <davem@...emloft.net>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] iproute2: add support for invisible qdisc dumping

On Mon, 27 Feb 2017, Phil Sutter wrote:

> > Support the new TCA_DUMP_INVISIBLE netlink attribute that allows asking 
> > kernel to perform 'full qdisc dump', as for historical reasons some of the 
> > default qdiscs are being hidden by the kernel.
> > 
> > The command syntax is being extended by voluntary 'invisible' argument to
> > 'tc qdisc show'.
> > 
> > Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> > ---
> >  tc/tc_qdisc.c | 25 +++++++++++++++++++++++--
> >  1 file changed, 23 insertions(+), 2 deletions(-)
> 
> Would you mind adding a description of the new keyword to tc man page as
> well?

Seems like tc manpage would need more updates, as it doesn't seem to 
reflect the '[ ingress | clsact ]' possibility either. So I'll send this 
as a followup patch, fixing all these at once.

> > diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c
> > index 3a3701c2..29da9269 100644
> > --- a/tc/tc_qdisc.c
> > +++ b/tc/tc_qdisc.c
> > @@ -34,7 +34,7 @@ static int usage(void)
> >  	fprintf(stderr, "       [ stab [ help | STAB_OPTIONS] ]\n");
> >  	fprintf(stderr, "       [ [ QDISC_KIND ] [ help | OPTIONS ] ]\n");
> >  	fprintf(stderr, "\n");
> > -	fprintf(stderr, "       tc qdisc show [ dev STRING ] [ ingress | clsact ]\n");
> > +	fprintf(stderr, "       tc qdisc show [ dev STRING ] [ ingress | clsact | invisible ]\n");
> 
> Doesn't look like these are mutually exclusive. Therefore I would
> suggest fixing the syntax to:
> 
> | +	fprintf(stderr, "       tc qdisc show [ dev STRING ] [ ingress | clsact ] [ invisible ]\n");

Makes sense, will include this in v2.

Thanks,

-- 
Jiri Kosina
SUSE Labs