linux-kernel - Re: [PATCH] livepatch: make klp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170308130619.3ixmcvw6rcy5od32@treble>
Date:   Wed, 8 Mar 2017 07:06:19 -0600
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Jessica Yu <jeyu@...hat.com>, Miroslav Benes <mbenes@...e.cz>,
        Petr Mladek <pmladek@...e.com>, live-patching@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] livepatch: make klp_mutex proper part of API

On Wed, Mar 08, 2017 at 10:16:00AM +0100, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@...e.cz>
> 
> klp_mutex is shared between core.c and transition.c, and as such would 
> rather be properly located in livepatch.h so that we don't have to play 
> 'extern' games from .c sources.
> 
> This also silences sparse warning (wrongly) suggesting that klp_mutex 
> should be defined static.

include/linux/livepatch.h is the public interface, whereas klp_mutex is
a private implementation detail.  I think it would be a better fit in
kernel/livepatch/core.h (though that file doesn't yet exist).

-- 
Josh