linux-kernel - Re: [PATCH v5 2/5] powerpc: kretprobes: override default function entry offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170308164644.GK11046@naverao1-tp.localdomain>
Date:   Wed, 8 Mar 2017 22:16:44 +0530
From:   "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org,
        Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>
Subject: Re: [PATCH v5 2/5] powerpc: kretprobes: override default function
 entry offset

On 2017/03/08 11:29AM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 08, 2017 at 07:54:12PM +0530, Naveen N. Rao escreveu:
> > Hi Michael,
> > 
> > On 2017/03/08 09:43PM, Michael Ellerman wrote:
> > > "Naveen N. Rao" <naveen.n.rao@...ux.vnet.ibm.com> writes:
> > > 
> > > > With ABIv2, we offset 8 bytes into a function to get at the local entry
> > > > point.
> > > >
> > > > Acked-by: Ananth N Mavinakayanahalli <ananth@...ux.vnet.ibm.com>
> > > > Acked-by: Michael Ellerman <mpe@...erman.id.au>
> > > > Signed-off-by: Naveen N. Rao <naveen.n.rao@...ux.vnet.ibm.com>
> > > > ---
> > > >  arch/powerpc/kernel/kprobes.c | 9 +++++++++
> > > >  1 file changed, 9 insertions(+)
> > > 
> > > I'm OK with this change, and I'm happy for it to go with the rest of the
> > > series via acme's tree:
> > > 
> > > Acked-by: Michael Ellerman <mpe@...erman.id.au>
> > > 
> > > 
> > > But, you've also sent a series to do KPROBES_ON_FTRACE, and that also
> > > touches this function, see the 2nd to last hunk at:
> > > 
> > >   https://patchwork.ozlabs.org/patch/730675/
> > > 
> > > 
> > > If this goes via acme's tree it will be awkward for me to merge the
> > > series above via the powerpc tree.
> > 
> > Ah yes, indeed.
> > 
> > > 
> > > So we could do topic branches and so on, or we could just drop this
> > > patch from this series, and I'll merge it as part of the other series.
> > > It won't do anything useful until it's merged with a tree that also has
> > > the rest of this series. Or something else I haven't thought of.
> > 
> > The arch-independent change that this depends on has been picked up by 
> > Arnaldo and pushed to Ingo:
> > https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg115211.html
> > 
> > I'm guessing this will go into v4.11? In which case, this powerpc patch 
> > should also go in. Otherwise kretprobes will be broken on powerpc64le.
> 
> I don't think so, I've put it in a perf/core branch, meaning its not
> strictly fixes, could be processed in the next merge window if Ingo
> thinks we've passed the current merge window threshold for such kind of
> changes, and he merged it into perf/core, meaning, at this time, that it
> is aimed for 4.12.

Ah, thanks for clarifying.

> 
> > I wasn't sure if you were planning on picking up KPROBES_ON_FTRACE for 
> > v4.11. If so, it would be good to take this patch through the powerpc 
> > tree. Otherwise, this can go via Ingo's tree.
> 
> If you guys convince Ingo that this should go _now_, then just cherry
> pick what was merged into tip/perf/core that is needed for the arch
> specific stuff and go from there.

Ok, in hindsight, I think Michael's concern was actually for v4.12 
itself, in which case this particular patch can go via powerpc tree, 
while the rest of the patches in this series can go via your tree.

Michael?


Thanks,
Naveen