linux-kernel - Re: [PATCH] virtio: remove redundant check on error return err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJSP0QUEUgxKD51nLt6vEAbGP5Hq1KJ4UPU1Re72-6tR5FsPAw@mail.gmail.com>
Date:   Fri, 10 Mar 2017 11:36:52 +0800
From:   Stefan Hajnoczi <stefanha@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     "Michael S . Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Linux Virtualization <virtualization@...ts.linux-foundation.org>,
        kernel-janitors@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virtio: remove redundant check on error return err

On Tue, Mar 7, 2017 at 10:08 PM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> err has previously been checked for a -ve error return so this
> redundant check can be removed.
>
> Detected by CoverityScan, CID#1415271 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/virtio/virtio_pci_common.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
> index df548a6..ceb4395 100644
> --- a/drivers/virtio/virtio_pci_common.c
> +++ b/drivers/virtio/virtio_pci_common.c
> @@ -173,8 +173,6 @@ static int vp_find_vqs_msix(struct virtio_device *vdev, unsigned nvqs,
>                 if (err < 0)
>                         return err;
>         }
> -       if (err < 0)
> -               return err;
>
>         vp_dev->msix_vectors = nvectors;
>         vp_dev->msix_names = kmalloc_array(nvectors,

Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>