linux-kernel - Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to "samsung" directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Mar 2017 19:55:54 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Jaehoon Chung <jh80.chung@...sung.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        linux-kernel@...r.kernel.org, kgene@...nel.org, kamil@...as.org,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Javier Martinez Canillas <javier@....samsung.com>,
        linux-samsung-soc@...r.kernel.org
Subject: Re: [RFC PATCH] phy: samsung: move the Samsung specific phy files to
 "samsung" directory

On Fri, Mar 10, 2017 at 9:00 AM, Jaehoon Chung <jh80.chung@...sung.com> wrote:
> Hi All,
>
> On 03/09/2017 09:10 PM, Krzysztof Kozlowski wrote:
>> On Thu, Mar 9, 2017 at 1:56 PM, Kishon Vijay Abraham I <kishon@...com> wrote:
>>> Hi,
>>>
>>> On Thursday 09 March 2017 05:03 PM, Jaehoon Chung wrote:
>>>> Make the "samsung" directory and move the Samsung specific files to
>>>> there for maintaining the files relevant to Samsung.
>>>
>>> The number of phy drivers in drivers/phy is getting unmanageable. I think this
>>> is a good step to make it a little better. Can you also add a MAINTAINER for
>>> drivers/phy/samsung?
>>
>> There is such:
>>
>> 10903 SAMSUNG USB2 PHY DRIVER
>> 10904 M:      Kamil Debski <kamil@...as.org>
>> 10905 M:      Sylwester Nawrocki <s.nawrocki@...sung.com>
>> 10906 L:      linux-kernel@...r.kernel.org
>> 10907 S:      Supported
>> 10908 F:      Documentation/devicetree/bindings/phy/samsung-phy.txt
>> 10909 F:      Documentation/phy/samsung-usb2.txt
>> 10910 F:      drivers/phy/phy-exynos4210-usb2.c
>> 10911 F:      drivers/phy/phy-exynos4x12-usb2.c
>> 10912 F:      drivers/phy/phy-exynos5250-usb2.c
>> 10913 F:      drivers/phy/phy-s5pv210-usb2.c
>> 10914 F:      drivers/phy/phy-samsung-usb2.c
>> 10915 F:      drivers/phy/phy-samsung-usb2.h
>>
>> but this patchset does not update it. Paths *everywhere* have to be updated.
>
> Will update..How about the below updating?
> M:      Kamil Debski <kamil@...as.org>
> M:      Sylwester Nawrocki <s.nawrocki@...sung.com>
> M:      Jaehoon Chung <jh80.chung@...sung.com>
> L:      linux-kernel@...r.kernel.org
> S:      Supported
> F:      Documentation/devicetree/bindings/phy/samsung-phy.txt
> F:      Documentation/phy/samsung-usb2.txt
> F:      driver/phy/samsung/

Hm? Except recent phy-exynos-pcie you did not contribute to other PHY
drivers. You did not reviewed them on the lists. I think that
maintenance starts with reviewing... which did not happen in this
case.

Did you discuss it with existing maintainers (I know that Sylwester is
too polite... but I do not care about politics and I can say straight
from the shoulder).

Maybe you wanted:
SAMSUNG PHY DRIVERS
M:      Kamil Debski <kamil@...as.org>
M:      Sylwester Nawrocki <s.nawrocki@...sung.com>
L:      linux-kernel@...r.kernel.org
S:      Supported
F:      Documentation/devicetree/bindings/phy/samsung-phy.txt
F:      Documentation/phy/samsung-usb2.txt
F:      driver/phy/samsung/

SAMSUNG PCIE PHY DRIVER
M:      Jaehoon Chung <jh80.chung@...sung.com>
L:      linux-kernel@...r.kernel.org
S:      Supported
F:      driver/phy/samsung/phy-exynos-pcie.c

That looks much more sensible to me.

Best regards,
Krzysztof