linux-kernel - Re: [PATCH net, v1] dccp/tcp: fix routing redirect race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGHK07Cd8e6eDc2hRR6DL77PvFtFPSW2TJzvYf5PO8n38ThvqQ@mail.gmail.com>
Date:   Fri, 10 Mar 2017 16:05:19 +1100
From:   Jonathan Maxwell <jmaxwell37@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     gerrit@....abdn.ac.uk, David Miller <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        kuznet <kuznet@....inr.ac.ru>, jmorris <jmorris@...ei.org>,
        yoshfuji <yoshfuji@...ux-ipv6.org>, kaber <kaber@...sh.net>,
        Neal Cardwell <ncardwell@...gle.com>, dccp@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jon Maxwell <jmaxwell@...hat.com>,
        Eric Garver <egarver@...hat.com>,
        Hannes Sowa <hsowa@...hat.com>
Subject: Re: [PATCH net, v1] dccp/tcp: fix routing redirect race

On Fri, Mar 10, 2017 at 3:23 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Fri, 2017-03-10 at 14:31 +1100, Jon Maxwell wrote:
>> As Eric Dumazet pointed out this also needs to be fixed in IPv6.
>> v1: Contains the IPv6 patch as well.
>
>> Fixes: ceb3320610d6 ("ipv4: Kill routes during PMTU/redirect updates.")
>> Cc: Eric Garver <egarver@...hat.com>
>> Cc: Hannes Sowa <hsowa@...hat.com>
>> Signed-off-by: Jon Maxwell <jmaxwell37@...il.com>
>> ---
>>  net/dccp/ipv4.c     | 3 ++-
>>  net/ipv4/tcp_ipv4.c | 3 ++-
>>  net/ipv6/tcp_ipv6.c | 8 +++++---
>
> Hi Jon.
>
> You forgot net/dccp/ipv6.c
>
> dccp_v6_err() has the same issue.
>
>

Thanks Eric,

My bad. I'll fix that and post another patch.