[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20170312135423.GA911@kroah.com>
Date: Sun, 12 Mar 2017 14:54:23 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: simran singhal <singhalsimran0@...il.com>
Cc: mchehab@...nel.org, linux-media@...r.kernel.org,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
outreachy-kernel@...glegroups.com
Subject: Re: [PATCH v1] staging: media: Remove unused function
atomisp_set_stop_timeout()
On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote:
> The function atomisp_set_stop_timeout on being called, simply returns
> back. The function hasn't been mentioned in the TODO and doesn't have
> FIXME code around. Hence, atomisp_set_stop_timeout and its calls have been
> removed.
>
> This was done using Coccinelle.
>
> @@
> identifier f;
> @@
>
> void f(...) {
>
> -return;
>
> }
>
> Signed-off-by: simran singhal <singhalsimran0@...il.com>
> ---
> v1:
> -Change Subject to include name of function
> -change commit message to include the coccinelle script
You should also cc: the developers doing all of the current work on this
driver, Alan Cox, to get their comment if this really is something that
can be removed or not.
thanks,
greg k-h
Powered by blists - more mailing lists