linux-kernel - Re: [BUG] 4.11.0-rc1 panic on shutdown X61s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Mar 2017 15:55:08 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     lkml@...garu.com, linux-kernel <linux-kernel@...r.kernel.org>,
        vcaputo@...garu.com,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        intel-wired-lan@...ts.osuosl.org
Subject: Re: [BUG] 4.11.0-rc1 panic on shutdown X61s

On Sun, Mar 12, 2017 at 2:26 PM, Borislav Petkov <bp@...en8.de> wrote:
> On Sun, Mar 12, 2017 at 12:57:03PM +0100, Borislav Petkov wrote:
>> On Sat, Mar 11, 2017 at 09:37:23PM -0800, lkml@...garu.com wrote:
>> > Hello list,
>> >
>> > Here's a photo of the panic, on imgur to be kind to vger:
>> > http://imgur.com/a/wZI32
>> >
>> > I'm out on a sailboat so can't really do much, but had a chance with internet
>>
>> So you didn't bring another box with you on the sailboat to connect it to the
>> laptop over netconsole to catch full dmesg, did you?
>
> Hahah, you're so in luck: I just sent this mail and hibernated my laptop
> and got the same BUG. What's the chance of that happening?! Apparently
> big enough.
>
> But I was able to catch the warning before it too. So the question is,
> do you have an e1000e eth controller in that machine too?
>
> Because the symptoms below are consistent with the observed behavior:
> e1000e fails to initialize MSI interrupts for whatever reason and falls
> back to legacy interrupts.
>
> Then, PCI core shuts down and BUGs because the msi_list is empty.
>
> Anyway, lemme add e1000e people too to the fun thread.
>

The only change that IMHO matters happened between v4.10 and v4.11-rc1 is this:

@@ -6276,8 +6274,8 @@ static int e1000e_pm_freeze(struct device *dev)
                /* Quiesce the device without resetting the hardware */
                e1000e_down(adapter, false);
                e1000_free_irq(adapter);
+               e1000e_reset_interrupt_capability(adapter);
        }
-       e1000e_reset_interrupt_capability(adapter);

So, it apparently misses something for the other case, like
pci_disable_msi() call or so.

P.S. I'm not PCI or e1000e guy :-)

-- 
With Best Regards,
Andy Shevchenko