linux-kernel - Re: [PATCH] hid: cp2112: select GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170313094819.GD4378@mail.corp.redhat.com>
Date:   Mon, 13 Mar 2017 10:48:19 +0100
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Jiri Kosina <jikos@...nel.org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid: cp2112: select GPIOLIB_IRQCHIP instead of depending
 on it

On Mar 12 2017 or thereabouts, Bartosz Golaszewski wrote:
> GPIOLIB_IRQCHIP is not visible to user, so we can't depend on it.
> 
> Depend on GPIOLIB but select GPIOLIB_IRQCHIP.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> ---

Makes sense. Good catch

Acked-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

>  drivers/hid/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 1aeb80e..00e2809 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -214,7 +214,8 @@ config HID_CMEDIA
>  
>  config HID_CP2112
>  	tristate "Silicon Labs CP2112 HID USB-to-SMBus Bridge support"
> -	depends on USB_HID && I2C && GPIOLIB && GPIOLIB_IRQCHIP
> +	depends on USB_HID && I2C && GPIOLIB
> +	select GPIOLIB_IRQCHIP
>  	---help---
>  	Support for Silicon Labs CP2112 HID USB to SMBus Master Bridge.
>  	This is a HID device driver which registers as an i2c adapter
> -- 
> 2.9.3
>