linux-kernel - Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc and memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170313115129.GC4136@mwanda>
Date:   Mon, 13 Mar 2017 14:51:29 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Daeseok Youn <daeseok.youn@...il.com>
Cc:     mchehab@...nel.org, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, alan@...ux.intel.com,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] staging: atomisp: use k{v}zalloc instead of k{v}alloc
 and memset

On Mon, Mar 13, 2017 at 07:54:21PM +0900, Daeseok Youn wrote:
> If the atomisp_kernel_zalloc() has "true" as a second parameter, it
> tries to allocate zeroing memory from kmalloc(vmalloc) and memset.
> But using kzalloc is rather than kmalloc followed by memset with 0.
> (vzalloc is for same reason with kzalloc)
> 
> And also atomisp_kernel_malloc() can be used with
> atomisp_kernel_zalloc(<size>, false);
> 

We should just change all the callers to kvmalloc() and kvzmalloc().

regards,
dan carpenter