linux-kernel - Re: [PATCH] kasan: Add a prototype of task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <37ae8571-2e97-1999-36cb-f2d5690f62e5@virtuozzo.com>
Date:   Mon, 13 Mar 2017 18:01:27 +0300
From:   Andrey Ryabinin <aryabinin@...tuozzo.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Masami Hiramatsu <mhiramat@...nel.org>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        <kasan-dev@...glegroups.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kasan: Add a prototype of task_struct to avoid warning



On 03/13/2017 05:14 PM, Arnd Bergmann wrote:
> From: Masami Hiramatsu <mhiramat@...nel.org>
> 
> Add a prototype of task_struct to fix below warning on arm64.
> 
> In file included from arch/arm64/kernel/probes/kprobes.c:19:0:
> include/linux/kasan.h:81:132: error: 'struct task_struct' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>  static inline void kasan_unpoison_task_stack(struct task_struct *task) {}
> 
> As same as other types (kmem_cache, page, and vm_struct) this adds a
> prototype of task_struct data structure on top of kasan.h.
> 
> [arnd] A related warning was fixed before, but now appears in a different
> line in the same file in v4.11-rc2. The patch from Masami Hiramatsu
> still seems appropriate, so let's take his version.
> 
> Link: https://patchwork.kernel.org/patch/9569839/
> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Andrey Ryabinin <aryabinin@...tuozzo.com>
> Cc: Alexander Potapenko <glider@...gle.com>
> Cc: Dmitry Vyukov <dvyukov@...gle.com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Fixes: 71af2ed5eeea ("kasan, sched/headers: Remove <linux/sched.h> from <linux/kasan.h>")
Acked-by: Andrey Ryabinin <aryabinin@...tuozzo.com>

> ---
>  include/linux/kasan.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> index 1c823bef4c15..5734480c9590 100644
> --- a/include/linux/kasan.h
> +++ b/include/linux/kasan.h
> @@ -6,6 +6,7 @@
>  struct kmem_cache;
>  struct page;
>  struct vm_struct;
> +struct task_struct;
>  
>  #ifdef CONFIG_KASAN
>  
>