linux-kernel - Re: [PATCH] perf: fix typo in function switch_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170313150004.GQ2750@kernel.org>
Date:   Mon, 13 Mar 2017 12:00:04 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     changbin.du@...el.com
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org, Feng Tang <feng.tang@...el.com>
Subject: Re: [PATCH] perf: fix typo in function switch_data_file

Em Mon, Mar 13, 2017 at 07:46:52PM +0800, changbin.du@...el.com escreveu:
> From: Changbin Du <changbin.du@...el.com>
> 
> Should clear buf abs_path, not options.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Changbin Du <changbin.du@...el.com>
> ---
>  tools/perf/ui/browsers/hists.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> index a6dae80..6fafe02 100644
> --- a/tools/perf/ui/browsers/hists.c
> +++ b/tools/perf/ui/browsers/hists.c
> @@ -2350,7 +2350,7 @@ static int switch_data_file(void)
>  		return ret;
>  
>  	memset(options, 0, sizeof(options));
> -	memset(options, 0, sizeof(abs_path));
> +	memset(abs_path, 0, sizeof(abs_path));
>  
>  	while ((dent = readdir(pwd_dir))) {
>  		char path[PATH_MAX];
> -- 
> 2.7.4