linux-kernel - Re: [PATCH 1/2] dt-bindings: ata: add DT bindings for ahci-dm816 SATA controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <61ee23f2-734b-f793-0054-364ce553ae5e@cogentembedded.com>
Date:   Mon, 13 Mar 2017 20:27:34 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Tejun Heo <tj@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Michael Turquette <mturquette@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Patrick Titiano <ptitiano@...libre.com>,
        linux-ide@...r.kernel.org,
        linux-devicetree <devicetree@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: ata: add DT bindings for ahci-dm816 SATA
 controller

On 03/13/2017 08:08 PM, Bartosz Golaszewski wrote:

>>> Add DT bindings for the onboard SATA controller present on the DM816x
>>> SoCs.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
>>> ---
>>>  Documentation/devicetree/bindings/ata/ahci-dm816.txt | 20
>>> ++++++++++++++++++++
>>>  1 file changed, 20 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/ata/ahci-dm816.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/ata/ahci-dm816.txt
>>> b/Documentation/devicetree/bindings/ata/ahci-dm816.txt
>>> new file mode 100644
>>> index 0000000..b87ed5a
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/ata/ahci-dm816.txt
>>> @@ -0,0 +1,20 @@
>>> +Device tree binding for the TI DM816 AHCI SATA Controller
>>> +---------------------------------------------------------
>>> +
>>> +Required properties:
>>> +  - compatible: must be "ti,dm816-ahci"
>>> +  - reg: physical base address and size of the register region used by
>>> +         the controller (as defined by the AHCI 1.1 standard)
>>> +  - interrupts: interrupt specifier (refer to the interrupt binding)
>>> +  - clocks: clock specifiers (refer to the clock binding); two clocks
>>
>>
>>    There should be a phandle preceding the clock specifier, all new such
>> props are different to the old "interrupts" (which had phandle in a separate
>> "interrupt-parent" prop).

> I'm afraid I don't understand - could you point me to an example?

    Have you read Documentation/devicetree/bindings/clock/clock-bindings.txt, 
on clock consumers?
    In fact, your own example below doesn't have clock specifiers, only phandles.

>>> +            must be specified: the functional clock and an external
>>> +            reference clock
>>> +
>>> +Example:
>>> +
>>> +       sata: sata@...40000 {
>>> +               compatible = "ti,dm816-ahci";
>>> +               reg = <0x4a140000 0xffff>;
[...]
>>> +               interrupts = <16>;
>>> +               clocks = <&sysclk5_ck>, <&sata_refclk>;
>>> +       };
>>>

> Thanks,
> Bartosz Golaszewski

MBR, Sergei