linux-kernel - Re: [PATCH] firmware: ti_sci: fix strncat length check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e3a448e-da7e-4da5-96bf-327da2a8c7d0@oracle.com>
Date:   Tue, 14 Mar 2017 14:19:18 -0700
From:   "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
To:     Arnd Bergmann <arnd@...db.de>, Nishanth Menon <nm@...com>,
        Tero Kristo <t-kristo@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>
Cc:     Dave Gerlach <d-gerlach@...com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: ti_sci: fix strncat length check

On 3/14/17 2:11 PM, Arnd Bergmann wrote:
> gcc-7 notices that the length we pass to strncat is wrong:
>
> drivers/firmware/ti_sci.c: In function 'ti_sci_probe':
> drivers/firmware/ti_sci.c:204:32: error: specified bound 50 equals the size of the destination [-Werror=stringop-overflow=]
>
> Instead of the total length, we must pass the length of the
> remaining space here.
>
> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol")
> Acked-by: Nishanth Menon <nm@...com>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> Originally submitted on Jan 11, patch is still needed on Linux-4.11-rc2.

Looks fine to me Arnd. Will you be applying it to SOC driver branch ?

Acked-by: Santosh Shilimkar <ssantosh@...nel.org>