linux-kernel - Re: [PATCH] firmware: ti_sci: fix strncat length check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 19 May 2017 10:32:23 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
Cc:     Nishanth Menon <nm@...com>, Tero Kristo <t-kristo@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Dave Gerlach <d-gerlach@...com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        arm-soc <arm@...nel.org>
Subject: Re: [PATCH] firmware: ti_sci: fix strncat length check

On Tue, Mar 14, 2017 at 10:19 PM, santosh.shilimkar@...cle.com
<santosh.shilimkar@...cle.com> wrote:
> On 3/14/17 2:11 PM, Arnd Bergmann wrote:
>>
>> gcc-7 notices that the length we pass to strncat is wrong:
>>
>> drivers/firmware/ti_sci.c: In function 'ti_sci_probe':
>> drivers/firmware/ti_sci.c:204:32: error: specified bound 50 equals the
>> size of the destination [-Werror=stringop-overflow=]
>>
>> Instead of the total length, we must pass the length of the
>> remaining space here.
>>
>> Fixes: aa276781a64a ("firmware: Add basic support for TI System Control
>> Interface (TI-SCI) protocol")
>> Acked-by: Nishanth Menon <nm@...com>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>> Originally submitted on Jan 11, patch is still needed on Linux-4.11-rc2.
>
>
> Looks fine to me Arnd. Will you be applying it to SOC driver branch ?
>
> Acked-by: Santosh Shilimkar <ssantosh@...nel.org>

For some reason I dropped the ball in this patch, applied to arm-soc fixes
now and marked for stable backports.

        Arnd