linux-kernel - Re: [PATCH RESEND v1] locking/ww_mutex: Prevent read of uninitialized memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170314214835.GP2118@nuc-i3427.alporthouse.com>
Date:   Tue, 14 Mar 2017 21:48:35 +0000
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Robert Foss <robert.foss@...labora.com>
Cc:     peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND v1] locking/ww_mutex: Prevent read of
 uninitialized memory

On Tue, Mar 14, 2017 at 03:44:02PM -0400, Robert Foss wrote:
> On "missed ABBA deadlock" abba.result is read, but not initialized
> in all situations.
> 
> Detected by CoverityScan, CID#1402035 ("Uninitialized scalar variable")

It's unconditionally set by the worker, and only accessed by the parent
after the flush_work() barrier.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre