linux-kernel - Re: [PATCH RESEND v1] locking/ww_mutex: Prevent read of uninitialized memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201703170927.IlD5NMp3%fengguang.wu@intel.com>
Date:   Fri, 17 Mar 2017 09:50:04 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Robert Foss <robert.foss@...labora.com>
Cc:     kbuild-all@...org, peterz@...radead.org, mingo@...hat.com,
        linux-kernel@...r.kernel.org,
        Robert Foss <robert.foss@...labora.com>
Subject: Re: [PATCH RESEND v1] locking/ww_mutex: Prevent read of
 uninitialized memory

Hi Robert,

[auto build test WARNING on tip/locking/core]
[also build test WARNING on v4.11-rc2 next-20170310]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Robert-Foss/locking-ww_mutex-Prevent-read-of-uninitialized-memory/20170317-085627
config: x86_64-randconfig-i0-201711 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   kernel/locking/test-ww_mutex.c: In function 'test_abba':
>> kernel/locking/test-ww_mutex.c:199:9: warning: missing braces around initializer [-Wmissing-braces]
     struct test_abba abba = { 0 };
            ^
   kernel/locking/test-ww_mutex.c:199:9: warning: (near initialization for 'abba.work') [-Wmissing-braces]

vim +199 kernel/locking/test-ww_mutex.c

   183		if (abba->resolve && err == -EDEADLK) {
   184			ww_mutex_unlock(&abba->b_mutex);
   185			ww_mutex_lock_slow(&abba->a_mutex, &ctx);
   186			err = ww_mutex_lock(&abba->b_mutex, &ctx);
   187		}
   188	
   189		if (!err)
   190			ww_mutex_unlock(&abba->a_mutex);
   191		ww_mutex_unlock(&abba->b_mutex);
   192		ww_acquire_fini(&ctx);
   193	
   194		abba->result = err;
   195	}
   196	
   197	static int test_abba(bool resolve)
   198	{
 > 199		struct test_abba abba = { 0 };
   200		struct ww_acquire_ctx ctx;
   201		int err, ret;
   202	
   203		ww_mutex_init(&abba.a_mutex, &ww_class);
   204		ww_mutex_init(&abba.b_mutex, &ww_class);
   205		INIT_WORK_ONSTACK(&abba.work, test_abba_work);
   206		init_completion(&abba.a_ready);
   207		init_completion(&abba.b_ready);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (27082 bytes)