linux-kernel - Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1e067f1-e82f-7692-bcc2-e3549887be63@arm.com>
Date:   Tue, 14 Mar 2017 16:14:04 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Aleksey Makarov <aleksey.makarov@...aro.org>,
        linux-serial@...r.kernel.org
Cc:     Sudeep Holla <sudeep.holla@....com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Peter Hurley <peter@...leysoftware.com>,
        Russell King <linux@...linux.org.uk>,
        Jiri Slaby <jslaby@...e.com>,
        Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching
 pl011 console"



On 01/03/17 15:23, Aleksey Makarov wrote:
> The original patch makes the condition always true, so it is wrong.
> 
> It masks (but not fixes) the bug described in the commit message
> but introduces a regression (no console is selected by SPCR)
> in regular (no 'console=ttyAMA') case.
> 
> s/||/&&/ would not fix the problem as the root cause was identified
> incorrectly.
> 
> This reverts commit aea9a80ba98a0c9b4de88850260e9fbdcc98360b.
> 

Sorry for that, I will test your patches and respond to that. For this
patch:

Acked-by: Sudeep Holla <sudeep.holla@....com>

-- 
Regards,
Sudeep